Data serialization fix #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erting between the header and payload writes
|
When creating this, I did not personally use the encrypted or stateful variants, and I haven't echoed any changes to those implementations. It's possible that these changes should also be performed there to keep each of them in sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the KeepAlive pings could cause serialization errors by injecting data in-between a write header and payload. This would cause the receiving reader to receive data that was prefixed by the Ping's size header and exception.
By ensuring that only one thread has access to the writer at a time, we can eliminate this risk and ensure the integrity of Header/Payload pairs.
I also changed the second size header byte to be a modulus operation. Even over millions of iterations, modern compiled modulus is still approximately the same performance. That said, however, there was nothing wrong with the previous calculation, I just find modulus to be more clear in intent.